Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event serialization testing #9573

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Add event serialization testing #9573

merged 4 commits into from
Jan 22, 2025

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Dec 17, 2024

Issue
Resolves #9517

Approach
Add serialization roundtrip for all events generated by EverestRunModel

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava self-assigned this Dec 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.74%. Comparing base (790933d) to head (9cfb9d8).
Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/ensemble_evaluator/snapshot.py 94.11% 1 Missing ⚠️
src/ert/run_models/event.py 97.67% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9573      +/-   ##
==========================================
+ Coverage   91.71%   91.74%   +0.02%     
==========================================
  Files         429      426       -3     
  Lines       26672    26589      -83     
==========================================
- Hits        24463    24393      -70     
+ Misses       2209     2196      -13
Flag Coverage Δ
cli-tests 39.80% <41.93%> (+0.09%) ⬆️
everest-models-test 34.16% <40.32%> (+0.02%) ⬆️
gui-tests 74.23% <41.93%> (+2.42%) ⬆️
integration-test 37.98% <40.32%> (-0.29%) ⬇️
performance-tests 51.55% <41.93%> (-0.11%) ⬇️
test 39.52% <40.32%> (-0.05%) ⬇️
unit-tests 74.27% <96.77%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9573 will not alter performance

Comparing DanSava:test-event-serialization (9abf27f) with main (4057a98)

Summary

✅ 24 untouched benchmarks

@DanSava DanSava force-pushed the test-event-serialization branch from 261b703 to bdac9c6 Compare December 17, 2024 14:02
@DanSava DanSava force-pushed the test-event-serialization branch 5 times, most recently from 7089a3b to 9c6ec15 Compare January 8, 2025 12:55
@DanSava DanSava added the release-notes:improvement Automatically categorise as improvement in release notes label Jan 10, 2025
oyvindeide
oyvindeide reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some suggestions and questions

src/ert/ensemble_evaluator/snapshot.py Outdated Show resolved Hide resolved
src/ert/ensemble_evaluator/snapshot.py Outdated Show resolved Hide resolved
src/ert/run_models/event.py Outdated Show resolved Hide resolved
src/ert/run_models/event.py Outdated Show resolved Hide resolved
src/ert/run_models/event.py Show resolved Hide resolved
@DanSava DanSava force-pushed the test-event-serialization branch 7 times, most recently from 068f567 to 3436a3e Compare January 20, 2025 08:21
oyvindeide
oyvindeide approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Remember to squash the review commit. I had one comment regarding @dataclass, which you can take into account if you agree.

@DanSava DanSava force-pushed the test-event-serialization branch 2 times, most recently from 60455e1 to 741e418 Compare January 22, 2025 15:08
@DanSava DanSava force-pushed the test-event-serialization branch from 741e418 to 9abf27f Compare January 22, 2025 15:10
@DanSava DanSava merged commit 905fb9a into equinor:main Jan 22, 2025
33 checks passed
@DanSava DanSava deleted the test-event-serialization branch January 22, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyvindeide oyvindeide oyvindeide approved these changes

Assignees

@DanSava DanSava

Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure events can be serialized
3 participants
@DanSava @codecov-commenter @oyvindeide